Critical Issues (P1)

These issues will throw PHP Error (not Exception) at runtime, which is not caught by the existing catch (\Exception $ex) blocks. This will abort transactions and cause data loss.

1. SummitAttendeeAuditLogFormatter.php:20

Problem: SummitAttendee has getSurname(), not getLastName()

// Current (broken):
$name = trim(($subject->getFirstName() ?? '') . ' ' . ($subject->getLastName() ?? '')) ?: 'Unknown Attendee';

// Fix:
$name = trim(($subject->getFirstName() ?? '') . ' ' . ($subject->getSurname() ?? '')) ?: 'Unknown Attendee';

2. SummitAttendeeBadgeAuditLogFormatter.php:19-21

Problem: Two issues:

• SummitAttendeeBadge doesn't have getOwner() — must go through getTicket()
• Owner is SummitAttendee which has getSurname(), not getLastName()

// Current (broken):
$id = $subject->getId() ?? 'unknown';
$owner = $subject->getOwner();
$owner_name = $owner ? trim(($owner->getFirstName() ?? '') . ' ' . ($owner->getLastName() ?? '')) : 'Unknown Owner';

// Fix:
$id = $subject->getId() ?? 'unknown';
$ticket = $subject->getTicket();
$owner = $ticket?->getOwner();
$owner_name = $owner ? trim(($owner->getFirstName() ?? '') . ' ' . ($owner->getSurname() ?? '')) : 'Unknown Owner';

3. SummitAttendeeTicketAuditLogFormatter.php:21

Problem: getOwner() returns SummitAttendee which has getSurname(), not getLastName()

// Current (broken):
$owner_name = $owner ? trim(($owner->getFirstName() ?? '') . ' ' . ($owner->getLastName() ?? '')) : 'Unknown Owner';

// Fix:
$owner_name = $owner ? trim(($owner->getFirstName() ?? '') . ' ' . ($owner->getSurname() ?? '')) : 'Unknown Owner';

4. SummitAttendeeNoteAuditLogFormatter.php:21

Problem: getOwner() returns SummitAttendee which has getSurname(), not getLastName()

// Current (broken):
$owner_name = $owner ? trim(($owner->getFirstName() ?? '') . ' ' . ($owner->getLastName() ?? '')) : 'Unknown Owner';

// Fix:
$owner_name = $owner ? trim(($owner->getFirstName() ?? '') . ' ' . ($owner->getSurname() ?? '')) : 'Unknown Owner';

Minor Housekeeping:
You're also missing Copyright headers on the new files. Check the existing formatters for examples:
/**

• Copyright 2025 OpenStack Foundation
• Licensed under the Apache License, Version 2.0 (the "License");
• you may not use this file except in compliance with the License.
• You may obtain a copy of the License at
• http://www.apache.org/licenses/LICENSE-2.0
• Unless required by applicable law or agreed to in writing, software
• distributed under the License is distributed on an "AS IS" BASIS,
• WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
• See the License for the specific language governing permissions and
• limitations under the License.
  **/

If this will in fact be Unit Tested with the change introduced with PR 479 then it looks good. Approved.

LGTM